go.mod, compiler: bump minimum Go version to 1.23#5302
go.mod, compiler: bump minimum Go version to 1.23#5302deadprogram merged 2 commits intotinygo-org:devfrom
Conversation
|
Hm, fun, I guess some of tinygo is not |
|
Also: |
|
I would agree that we can bump the minimum version. Anyone else have any feedback before I squash/merge? |
|
@jakebailey do you want to squash/rebase these commits yourself? |
|
Sure, I just assumed you did that with GitHub squash merge itself. |
I think there are a couple atomic commits in this PR so better to not squash it all together into 1. |
20e566b to
a00f25e
Compare
|
Rebased into two commits which should pass tests individually. |
|
Hm, CI fails, but I think this is a flake? I did not change the code in the PR. |
a00f25e to
b496678
Compare
aykevl
left a comment
There was a problem hiding this comment.
If I understand correctly, by dropping Go 1.22 support we add support for type aliases? If so, yeah that seems reasonable.
This enables gotypesalias=1 by default, which is needed for generic type aliases to work correctly in go/types.
b496678 to
61fb60f
Compare
|
Thank you very much @jakebailey for the improvements and to @aykevl for helping review. Now merging. |
Having
go1.22ingo.modcausesgotypesalias=0to be the default, even if the other parts of the toolchain are Go 1.23+ or higher. Bumping the minimum version resolves this, and I added a test.In searching for docs/CI to update, I found one TODO that said it should be done in 1.23+, so, I did that too.
Related: #4894