Skip to content

fix interp: unknown type kind in markExternalValue when compiling libsecp256k1 #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hectorchu wants to merge 3 commits into from
Closed

fix interp: unknown type kind in markExternalValue when compiling libsecp256k1 #5293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c711416
fix interp: unknown type kind in markExternalValue when compiling lib…
hectorchu Apr 12, 2026
66885b1
skip vectors, they don't contain pointers
hectorchu Apr 17, 2026
1f2e53e
VectorTypeKind: this is similar to an array, and needs the element ty…
hectorchu Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion interp/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ func (mv *memoryView) markExternal(llvmValue llvm.Value, mark uint8) error {
return err
}
}
case llvm.ArrayTypeKind:
case llvm.ArrayTypeKind, llvm.VectorTypeKind:
numElements := llvmType.ArrayLength()
for i := 0; i < numElements; i++ {
element := mv.r.builder.CreateExtractValue(llvmValue, i, "")
Expand All @@ -231,6 +231,7 @@ func (mv *memoryView) markExternal(llvmValue llvm.Value, mark uint8) error {
return err
}
}
case llvm.MetadataTypeKind:
default:
return errors.New("interp: unknown type kind in markExternalValue")
}
Expand Down