feat: expose BootloaderFlashOffset on Flasher#39
Merged
deadprogram merged 1 commit intotinygo-org:mainfrom Apr 24, 2026
Merged
Conversation
The chip Definition struct already tracks BootloaderFlashOffset per target (0x0 for ESP32-S3/C3/C6/H2/C2, 0x1000 for ESP32/S2, 0x2000 for ESP32-C5/P4-Rev1). Expose it through a public accessor so library callers can validate image offsets without duplicating the chip→offset mapping. Returns (0, false) when the chip has not been detected yet, matching the sentinel pattern used by ChipType() (returns ChipAuto) and ChipName() (returns "Unknown").
Member
|
Thank you for the feature @jgangemi now merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chip Definition struct already tracks BootloaderFlashOffset per
target (0x0 for ESP32-S3/C3/C6/H2/C2, 0x1000 for ESP32/S2, 0x2000 for
ESP32-C5/P4-Rev1). Expose it through a public accessor so library
callers can validate image offsets without duplicating the chip→offset
mapping.
Returns (0, false) when the chip has not been detected yet, matching
the sentinel pattern used by ChipType() (returns ChipAuto) and
ChipName() (returns "Unknown").