Skip to content

Change max zoom from 15 to 16 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peitili wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change max zoom from 15 to 16 #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
568fefe
Change max zoom from 15 to 16
peitilisc Jun 1, 2021
3fda602
remove unused import
peitilisc Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
MAX_TILE_ZOOM = 15 # 15 tilezen's max supported zoom

@nvkelso nvkelso Jun 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We play some tricks here with max zoom and tile sizes. For 256 tiles I recall the max zoom is 16, but for 512 tiles it's effectively 15, but when we build 256 tiles and 512 tiles we send the precut 256 zoom 16 tile for the 512 zoom 15 request. It's unclear to me what this MAX_TILE_ZOOM is referring to and what it means in the context of a 512 px tile size only build. Do you know? Otherwise I'll do some reading...

@peitili peitili Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We play some tricks here with max zoom and tile sizes. For 256 tiles I recall the max zoom is 16, but for 512 tiles it's effectively 15, but when we build 256 tiles and 512 tiles we send the precut 256 zoom 16 tile for the 512 zoom 15 request. It's unclear to me what this MAX_TILE_ZOOM is referring to and what it means in the context of a 512 px tile size only build. Do you know? Otherwise I'll do some reading...

The variable defined here is for bbox build, it iterate all the zooms up to MAX_TILE_ZOOM to find tiles that touches the bounding box.

@nvkelso nvkelso Jun 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM

MAX_TILE_ZOOM = 16 # tilezen's default max supported zoom
MIN_TILE_ZOOM = 0