Skip to content

Add support for deployment on Goerli testnet #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkuba merged 12 commits into from
Aug 9, 2022
Merged

Add support for deployment on Goerli testnet #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5b11755
Add support for deployment on Goerli testnet
michalinacienciala Jul 11, 2022
9f10e2e
Remove Ropsten-related config from deployment job
michalinacienciala Jul 13, 2022
08c0311
Bump version of custom CI actions to v2
michalinacienciala Jul 15, 2022
edb2660
Use tag when resolving `tbtc` contracts
michalinacienciala Aug 2, 2022
0912bad
Remove check of `environment` in deployment job
michalinacienciala Aug 2, 2022
b15f9e9
Add missing linebreak in the command for resolving contracts
michalinacienciala Aug 3, 2022
9b1d059
Update names of the CI modules
michalinacienciala Aug 5, 2022
c5a15f4
Don't specify the licence when running etherscan-verify
michalinacienciala Aug 9, 2022
36b5291
Remove unwanted artifacts before verifying contracts on Etherscan
michalinacienciala Aug 9, 2022
07435ee
Use deploy:test script in npm jobs
michalinacienciala Aug 9, 2022
0c4d945
Merge remote-tracking branch 'origin/main' into ci-goerli
michalinacienciala Aug 9, 2022
d94c87c
Remove testing configuration
michalinacienciala Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions .github/workflows/contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,25 +142,30 @@ jobs:
run: yarn install --frozen-lockfile

- name: Get upstream packages versions
uses: keep-network/ci/actions/upstream-builds-query@v1
uses: keep-network/ci/actions/upstream-builds-query@v2
id: upstream-builds-query
with:
upstream-builds: ${{ github.event.inputs.upstream_builds }}
query: tbtc-contracts-version = github.com/keep-network/tbtc/solidity#version
query: |
random-beacon-contracts-version = github.com/keep-network/keep-core/random-beacon#version
ecdsa-contracts-version = github.com/keep-network/keep-core/ecdsa#version

- name: Resolve latest contracts
run: yarn upgrade @keep-network/tbtc@${{ steps.upstream-builds-query.outputs.tbtc-contracts-version }}
run: |
yarn upgrade \
@keep-network/random-beacon@${{ steps.upstream-builds-query.outputs.random-beacon-contracts-version }} \
@keep-network/ecdsa@${{ steps.upstream-builds-query.outputs.ecdsa-contracts-version }} \
@keep-network/tbtc@${{ github.event.inputs.environment }}

- name: Configure tenderly
if: github.event.inputs.environment == 'ropsten'
env:
TENDERLY_TOKEN: ${{ secrets.TENDERLY_TOKEN }}
run: ./config_tenderly.sh

- name: Deploy contracts
- name: Deploy contract

@nkuba nkuba Aug 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

@michalinacienciala michalinacienciala Aug 9, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that got there by mistake, I'm fixing it as part of https://github.com/keep-network/tbtc-v2/pull/392/files.

env:
CHAIN_API_URL: ${{ secrets.KEEP_TEST_ETH_HOSTNAME_HTTP }}
CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.KEEP_TEST_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
CHAIN_API_URL: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }}
CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY: ${{ secrets.GOERLI_ETH_CONTRACT_OWNER_PRIVATE_KEY }}
run: yarn deploy --network ${{ github.event.inputs.environment }}

- name: Bump up package version
Expand All @@ -178,11 +183,11 @@ jobs:
run: npm publish --access=public --tag ${{ github.event.inputs.environment }} --network=${{ github.event.inputs.environment }}

- name: Notify CI about completion of the workflow
uses: keep-network/ci/actions/notify-workflow-completed@v1
uses: keep-network/ci/actions/notify-workflow-completed@v2
env:
GITHUB_TOKEN: ${{ secrets.CI_GITHUB_TOKEN }}
with:
module: "github.com/keep-network/tbtc-v2/solidity"
module: "github.com/keep-network/tbtc-v2"
url: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
environment: ${{ github.event.inputs.environment }}
upstream_builds: ${{ github.event.inputs.upstream_builds }}
Expand Down Expand Up @@ -231,19 +236,19 @@ jobs:
- name: Install needed dependencies
run: yarn install --frozen-lockfile

# If we don't remove the `ecdsa` and `tbtc` contracts from `node-modules`,
# the `etherscan-verify` plugins tries to verify them, which is not
# desired.
# If we don't remove the contracts from `node-modules`, the
# `etherscan-verify` plugins tries to verify them, which is not desired.
- name: Prepare for verification on Etherscan
run: |
rm -rf ./node_modules/@keep-network/ecdsa
rm -rf ./node_modules/@keep-network/tbtc
rm -rf ./node_modules/@keep-network/random-beacon/artifacts
rm -rf ./node_modules/@keep-network/ecdsa/artifacts
rm -rf ./node_modules/@keep-network/tbtc/artifacts

- name: Verify contracts on Etherscan
env:
ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
CHAIN_API_URL: ${{ secrets.KEEP_TEST_ETH_HOSTNAME_HTTP }}
run: yarn run hardhat --network ${{ github.event.inputs.environment }} etherscan-verify --license MIT
CHAIN_API_URL: ${{ secrets.GOERLI_ETH_HOSTNAME_HTTP }}
run: yarn run hardhat --network ${{ github.event.inputs.environment }} etherscan-verify

contracts-format:
needs: contracts-detect-changes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
# Deploy contracts to a local network to generate deployment artifacts that
# are required by dashboard compilation.
- name: Deploy contracts
run: yarn deploy --network hardhat --write true
run: yarn deploy:test --network hardhat --write true

- name: Bump up package version
id: npm-version-bump
Expand Down