docs: Update CONTRIBUTING.md, add MAINTAINERS.md#309
Merged
asraa merged 7 commits intotheupdateframework:masterfrom Jun 9, 2022
Merged
docs: Update CONTRIBUTING.md, add MAINTAINERS.md#309asraa merged 7 commits intotheupdateframework:masterfrom
asraa merged 7 commits intotheupdateframework:masterfrom
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Follow-up from theupdateframework#190 (thanks @asraa!). I did not add a DCO requirement at this point, as that was controversial in theupdateframework#190. I filed theupdateframework#308 to track that. I tried to address all *other* feedback in theupdateframework#190. Fixes theupdateframework#212. Fixes theupdateframework#306.
znewman01
requested review from
asraa,
ethan-lowman-dd,
hosseinsia,
joshuagl,
mnm678,
rdimitrov and
trishankatdatadog
znewman01
changed the title
asraa
reviewed
Jun 8, 2022
- TODO for testing instructions - Remove obsolete TODO
asraa
previously approved these changes
Jun 8, 2022
joshuagl
previously approved these changes
Jun 8, 2022
Member
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
Thanks for keeping this moving. I've made a few minor suggestions, but this LGTM as is.
joshuagl
approved these changes
Jun 8, 2022
asraa
approved these changes
Jun 9, 2022
mnm678
approved these changes
Jun 9, 2022
trishankatdatadog
approved these changes
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #190 (thanks @asraa!).
I did not add a DCO requirement at this point, as that was controversial in #190. I filed #308 to track that.
I tried to address all other feedback in #190.
Fixes #212.
Fixes #303.
Release Notes: N/A
Types of changes:
Description of the changes being introduced by the pull request:
Doc changes.
Please verify and check that the pull request fulfills the following requirements: