Skip to content

Fix linter errors raised by staticcheck #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuagl merged 4 commits into from
Mar 30, 2022
Merged

Fix linter errors raised by staticcheck #236

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92b967a
Fix linter errors raised by staticcheck
rdimitrov Mar 18, 2022
3704653
chore: delete empty target folder when doing tuf commit
rdimitrov Mar 25, 2022
941f7eb
chore: update unit test to expect a deleted targets folder
rdimitrov Mar 29, 2022
8c37598
chore: fix staticcheck error for local_store.go
rdimitrov Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions local_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,11 +431,9 @@ func (f *fileSystemStore) Commit(consistentSnapshot bool, versions map[string]in
return err
}
if !info.IsDir() && isTarget(rel) && needsRemoval(rel) {
//lint:ignore SA9003 empty branch
if err := os.Remove(path); err != nil {
// TODO: log / handle error
return err
Comment thread
rdimitrov marked this conversation as resolved.
}
// TODO: remove empty directory
Comment thread
rdimitrov marked this conversation as resolved.
}
return nil
}
Expand Down
2 changes: 1 addition & 1 deletion verify/db_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func TestDelegationsDB(t *testing.T) {
{
testName: "invalid keys",
delegations: &data.Delegations{Keys: map[string]*data.PublicKey{
"a": &data.PublicKey{Type: data.KeySchemeEd25519},
"a": {Type: data.KeySchemeEd25519},
}},
initErr: ErrWrongID{},
},
Expand Down