This repository was archived by the owner on Feb 13, 2019. It is now read-only.
Add Facebook image and description - #258
Open
MichaelButkovic wants to merge 2 commits into
Open
Conversation
| class Meta: | ||
| model = BaseSuperFeature | ||
|
|
||
| def to_representation(self, obj): |
Contributor
Author
There was a problem hiding this comment.
just adding this for documentation purposes, since this serializer isn't being used
Contributor
|
Just asking questions; Do we maybe want a method for a fallback description? like if no facebook description -> regular description. |
Contributor
Author
|
hm, not sure on that one. @spra85 any thoughts? |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mparent61 @benghaziboy