Skip to content

simple implementation of zoom in / zoom out Fixes #1274 - #1278

Open
bulbil wants to merge 4 commits into
mainfrom
canvas-panel-zoom
Open

simple implementation of zoom in / zoom out Fixes #1274#1278
bulbil wants to merge 4 commits into
mainfrom
canvas-panel-zoom

Conversation

@bulbil

@bulbil bulbil commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

#1274

Thank you for contributing to Quire! Please complete the form below to submit your pull request for review.

For the Title of this pull request, please use the format "Type/Issue-#: Brief description." For Type, the options are Fix, Feature, Docs, or Chore. Issue-# is only needed if this pull request addresses an existing issue.

Before submitting your PR, make sure that you can run the following commands: quire preview, quire build, quire pdf, and quire epub. If any of those core quire commands throw errors/yield unexpected behavior, we will NOT review the PR!

Checklist

Please put an X within the brackets that apply [X].

  • I have read the CONTRIBUTING.md file

  • I have made my changes in a new branch and not directly in the main branch

  • This pull request is ready for final review by the Quire team

Is this pull request related to an open issue? If so, what is the issue number?

Please briefly describe the goal of this pull request and how it may impact Quire's functionality.

Please describe the changes you made, and call out any details you think are particularly relevant for the Quire team to note in their review.

Does this pull request necessitate changes to Quire's documentation?

Include screenshots of before/after if applicable.

Additional Comments

  • Adds zoom buttons to canvas panel instances using markup from no longer used zoom button lightbox ui logic
  • Removes old reference to unused lightbox ui zoom buttons
  • Adds event handlers on canvas panel set up
  • Adds related styles to starter-default

thegetty/quire-starter-default#59

Screenshot 2026-08-12 at 1 12 16 PM Screenshot 2026-08-11 at 4 58 49 PM

@bulbil bulbil changed the title simple implementation of zoom in / zoom out 1274 simple implementation of zoom in / zoom out Fixes #1274 Aug 12, 2026
@bulbil
bulbil requested review from cbutcosk and geealbers August 12, 2026 17:40
@bulbil
bulbil marked this pull request as ready for review August 12, 2026 17:40
@bulbil
bulbil requested a review from a team August 12, 2026 17:44

@geealbers geealbers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks @bulbil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants