Fall back to FTS5/LIKE keyword search when Chroma is disabled#2055
Closed
Fall back to FTS5/LIKE keyword search when Chroma is disabled#2055
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
When CLAUDE_MEM_CHROMA_ENABLED is false and a text query is provided, search now gracefully falls back to SQLite FTS5 keyword matching (or LIKE-based search if FTS5 is unavailable) instead of returning a misleading error about uv/Python installation. Changes: - SessionSearch: Add FTS5 and LIKE text search paths for observations, sessions, and user prompts - SQLiteSearchStrategy: Pass query text through to SessionSearch - SearchOrchestrator: PATH 3 (no Chroma) falls back to SQLite keyword search - SearchManager: Legacy path uses FTS5/LIKE fallback instead of error Fixes #1960 Agent-Logs-Url: https://github.com/thedotmack/claude-mem/sessions/a83837bc-0b36-40fe-90e5-6f5806925e16 Co-authored-by: thedotmack <683968+thedotmack@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix text queries fallback to FTS5 when Chroma is disabled
Fall back to FTS5/LIKE keyword search when Chroma is disabled
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CLAUDE_MEM_CHROMA_ENABLED=false, search requests with aqueryparameter fail with a misleading error about installinguv, rather than using the already-available FTS5 infrastructure for keyword matching.Changes
SessionSearch: Add FTS5 keyword search path (with LIKE fallback when FTS5 unavailable) tosearchObservations,searchSessions,searchUserPrompts. AddhasFtsTables()(cached) andsanitizeFtsQuery()helpers.SQLiteSearchStrategy: Pass query text through toSessionSearchinstead of always passingundefined.SearchOrchestrator: PATH 3 (query + no Chroma) now delegates to SQLite strategy with query instead of returning empty results.SearchManager: Legacy path uses FTS5/LIKE fallback instead of settingchromaFailed=true.Search resolution order when Chroma is unavailable
User prompts use LIKE directly (no FTS5 table exists for
user_prompts).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either: