Repository navigation
fix: bump terraform-spring-boot-starter to 1.9.1 so stuck downloads time out (#3890) - #3904
Conversation
…ime out (terrakube-io#3890) 1.9.1 adds timeouts to the releases list and binary downloads, which could hang forever and leave the executor pod stuck on one job. The JSON plan/apply/destroy clients built in TerraformExecutorServiceImpl now copy the three new download timeouts from the configured client, like they already did for the releases URLs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@klinux can you include the properties to override the values if need it example: |
…variables TerraformDownloadResponseTimeout (60s), TerraformReleasesDownloadTimeout (2m) and TerraformBinaryDownloadTimeout (10m), like CustomTerraformReleasesUrl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Done in 44cab00. The three timeouts are now in Executor tests still pass (735, 0 failures). |
|
The The same stall happened on another PR today, at the same test: https://github.com/terrakube-io/terrakube/actions/runs/42998885446 ( Could you re-run the failed job? I do not have rights to do it. |
|
I tested locally and it is working good |
What changed and why?
Part of #3890.
This bumps
terraform-spring-boot-starterin the executor from 1.9.0 to 1.9.1. That release includes terrakube-io/terraform-spring-boot#112. In 1.9.0, the download of the releases list (index.json) and of the binaries could hang forever, and the executor pod then got stuck on that job. In 1.9.1 they time out and fail the job, or fall back to the previously cached releases list:io.terrakube.terraform.flags.*)downloadResponseTimeout(max idle time between reads)60sreleasesDownloadTimeout(whole releases list download)2mbinaryDownloadTimeout(whole binary download)10mTerraformExecutorServiceImplbuilds its own JSON plan, apply and destroy clients, and until now copied only the releases URLs from the configuredTerraformClient. They now copy the three timeouts as well, so an override applies to every download, not only to the main client.The defaults apply without any configuration. To override a timeout, set its executor environment variable, wired in
application.propertieslikeCustomTerraformReleasesUrl:TerraformDownloadResponseTimeoutdownloadResponseTimeout60sTerraformReleasesDownloadTimeoutreleasesDownloadTimeout2mTerraformBinaryDownloadTimeoutbinaryDownloadTimeout10mTesting
🤖 Generated with Claude Code