fix(common): preserve zero optional durations - #2249
Open
sidsri14 wants to merge 1 commit into
Open
Conversation
|
|
sidsri14
marked this pull request as ready for review
July 27, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updated
msOptionalToTsto treat onlynullandundefinedas absent values, so a numeric0duration is preserved and converted to a zero protobuf timestamp.Added a unit test covering
msOptionalToTs(0).Fixes #2233.
Validation
npx --yes pnpm@10.27.0 --filter @temporalio/proto buildnpx --yes pnpm@10.27.0 --filter @temporalio/common buildnpx --yes pnpm@10.27.0 --filter @temporalio/common testnpx --yes pnpm@10.27.0 exec eslint packages/common/src/time.ts packages/common/src/__tests__/test-time.tsnpx --yes pnpm@10.27.0 prettier --check packages/common/src/time.ts packages/common/src/__tests__/test-time.ts