Flake fix investigation - #1430
Open
Sushisource wants to merge 8 commits into
Open
Conversation
Sushisource
force-pushed
the
sj/flake-fix
branch
2 times, most recently
from
July 29, 2026 21:53
2b2748d to
7312729
Compare
A failed history fetch could arrive after zero-cache eviction removed the run, dropping the task token and blocking subsequent polls. Preserve the token and report unstored WFT failures through a stream-level action.
Sushisource
force-pushed
the
sj/flake-fix
branch
from
July 30, 2026 18:09
7312729 to
fd244e6
Compare
chris-olszewski
approved these changes
Jul 31, 2026
Comment on lines
+198
to
+202
| actions.extend( | ||
| activations | ||
| .into_iter() | ||
| .map(WorkflowStreamAction::Activation), | ||
| ); |
Member
There was a problem hiding this comment.
Might be worth a comment explaining importance of ordering activations after FailUnstoredWft variants.
Member
Author
There was a problem hiding this comment.
It actually doesn't matter really - it's just incidentally the most convenient way to combine the different types into the enum
Sushisource
force-pushed
the
sj/flake-fix
branch
from
July 31, 2026 21:58
05aa946 to
b3c061f
Compare
Sushisource
enabled auto-merge (squash)
July 31, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.