chore: add lefthook config, mise-bump workflow, update README - #1388
chore: add lefthook config, mise-bump workflow, update README#1388brucearctor wants to merge 2 commits into
Conversation
- Add lefthook.yml with pre-commit (fmt check) and pre-push (lint + check) hooks. Opt-in only: developers run 'lefthook install' to activate. - Add mise-bump.yml workflow that runs weekly (Monday 9am UTC) to check for outdated mise tool versions and open a bump PR. Complements dependabot (which does not support mise.toml). - Update README with mise install instructions and optional lefthook opt-in section.
chris-olszewski
left a comment
There was a problem hiding this comment.
Talked a bit about it with the team and we're pretty set on not wanting a tool config checked in that isn't necessary for development.
I also want to hold off on autobumping mise tooling until we see it become an actual issue.
|
I am not invested in lefthook specifically, it would help me [ and I imagine others ] if there is a semi-opionionated/opt-in way to handle that form of automation. I thought about keeping local, but imagined a similar comment of not desired if adding lefthook.yml [ or precommit.yml, ol prek ] to .gitignore at least. Ex: i forget to run lint, other things for pre-commit and/or prepush. Please have a guide published for the reccommendation, if this PR isn't the solution? Since I can't get fast-feedback from CI [ have to wait for someone on the temporal team to run CI -- that is a waste of a feedback cycle -- how can we solve for this? What are you, others doing for git hooks [ or instead of ]? |
Summary
Developer experience improvements: opt-in git hooks, automated tool version bumping, and updated onboarding docs.
PR 3 of 3 — independent, can merge in any order. See #1383 for the full effort.
Changes
lefthook.yml(new, opt-in only)cargo +nightly fmt --all -- --checkcargo lint+cargo checkNot auto-installed. Developers opt in:
.github/workflows/mise-bump.yml(new)Weekly scheduled workflow (Monday 9am UTC):
mise outdatedto detect new tool versionsmise up --bumpif updates existpeter-evans/create-pull-requestComplements existing dependabot config (which does not support
mise.toml).README.mdmise installRef #1383