Skip to content

fix: allow replacing worker client on default runtime #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sakshamm-Goyal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: allow replacing worker client on default runtime #1707

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d15e526
fix: allow replacing worker client on default runtime
Sakshamm-Goyal Jul 31, 2026
8c313d8
fix(worker): retain explicit runtime on client replacement
Sakshamm-Goyal Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion temporalio/worker/_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,10 @@ def client(self, value: temporalio.client.Client) -> None:
must be using the same runtime as the current client.
"""
bridge_client = _extract_bridge_client_for_worker(value)
if self._runtime is not bridge_client.config.runtime:
new_runtime = (
bridge_client.config.runtime or temporalio.runtime.Runtime.default()
Comment thread
Sakshamm-Goyal marked this conversation as resolved.
Outdated
)
if self._runtime is not new_runtime:
raise ValueError(
"New client is not on the same runtime as the existing client"
)
Expand Down
11 changes: 11 additions & 0 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6279,6 +6279,17 @@ async def test_workflow_replace_worker_client_diff_runtimes_fail(
worker.client = other_client


async def test_workflow_replace_worker_client_default_runtime(client: Client):
# Do not pass a runtime here: this client should lazily use the same
# default runtime as the worker.
default_runtime_client = await Client.connect(
client.service_client.config.target_host,
namespace=client.namespace,
)
async with new_worker(client, HelloWorkflow) as worker:
worker.client = default_runtime_client


@activity.defn(dynamic=True)
async def return_name_activity(_args: Sequence[RawValue]) -> str:
return activity.info().activity_type
Expand Down