Add keyboard message selection for screen reader users#30947
Open
rezabakhshilaktasaraei wants to merge 2 commits into
Open
Add keyboard message selection for screen reader users#30947rezabakhshilaktasaraei wants to merge 2 commits into
rezabakhshilaktasaraei wants to merge 2 commits into
Conversation
956aa59 to
942e20a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #30948 (the message-history action layer) - the first commit here is that PR; this one adds the second commit.
Keyboard multi-selection over history messages for screen reader users (screen-reader mode only, active only while the message list itself has keyboard focus):
changeSelectionAsGrouppaths mouse selection uses (selection cap, album atomicity, service-message exclusion), with the same repaint / top bar / announcement follow-ups.updateTopBarSelection/listSelectionChanged); with a screen reader active the list keeps focus, so keyboard users are not yanked out of the history mid-navigation.HistoryInnerandHistoryView::ListWidget(scheduled, pinned, replies, topics) get intentionally parallel implementations.