Skip to content

ci: pin msnodesqlv8 v5 to 5.2.1 on Node 20 #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhensby merged 1 commit into from
Jul 30, 2026
+15 −2
Merged

ci: pin msnodesqlv8 v5 to 5.2.1 on Node 20 #1883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,13 @@ jobs:
# brittle on the GitHub Windows images (e.g. the VS 2026 rollout on
# windows-2025 that node-gyp cannot detect). Coverage:
# v2: Node 18 v3: Node 18-20 v4: Node 18-24 v5: Node 20-24
#
# v5 is split: msnodesqlv8 5.2.2 dropped the Node 20 (ABI 115) win32-x64
# prebuild, so `@^5` (5.2.3+) is gated to Node 22-24 and Node 20 is pinned
# to 5.2.1 — the last v5 release that ships one. Upstream now builds
# prebuilds for Node 22/24/26 only, so a floating `@^5` will not regain a
# Node 20 prebuild; leaving Node 20 on `@^5` source-builds via node-gyp,
# which is slow on windows-2022 and fails outright on windows-2025.
- name: Install msnodesqlv8 v2
if: ${{ matrix.node == '18.x' }}
run: npm install --no-save msnodesqlv8@^2
Expand All @@ -180,11 +187,17 @@ jobs:
- name: Run msnodesqlv8 v4 tests
if: ${{ matrix.node == '18.x' || matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm run test-msnodesqlv8
- name: Install msnodesqlv8 v5 (Node 20, pinned)
if: ${{ matrix.node == '20.x' }}
run: npm install --no-save msnodesqlv8@5.2.1
- name: Run msnodesqlv8 v5 tests (Node 20, pinned)
if: ${{ matrix.node == '20.x' }}
run: npm run test-msnodesqlv8
- name: Install msnodesqlv8 v5
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm install --no-save msnodesqlv8@^5
- name: Run msnodesqlv8 v5 tests
if: ${{ matrix.node == '20.x' || matrix.node == '22.x' || matrix.node == '24.x' }}
if: ${{ matrix.node == '22.x' || matrix.node == '24.x' }}
run: npm run test-msnodesqlv8
release:
name: Release
Expand Down