-
Notifications
You must be signed in to change notification settings - Fork 1
develop #700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
develop #700
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5f0928b
feat: WebSocketServerHandshakeException 예외 처리
Finefinee b1c835c
merge: hotfix/socket/#692
hjbin-25 980a17e
refactor: 배틀 시작일 기준 내림차순 하여 정렬
hjbin-25 eeeb1de
fix: PENDING 상태의 배틀은 생성 기준 정렬
hjbin-25 bf9a41b
merge: refactor/battle-list-order/#695
hjbin-25 69b6819
fix: redis 타임아웃 시간 축소, 스케줄러 풀 확장
chaeyn 2f7ace6
merge: fix/redis-scheduler-stability/#698
chaeyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,7 @@ AND b.id NOT IN ( | |
| LEFT JOIN rivals r ON b.fk_rival_id = r.id | ||
| WHERE (r.fk_first_user_id = :userId OR r.fk_second_user_id = :userId) | ||
| AND b.battle_status NOT IN ('REJECTED', 'PENDING', 'CANCELED') | ||
| ORDER BY b.started_at DESC | ||
| """, nativeQuery = true) | ||
| List<BattleJpaEntity> findByUserIdWithOutRejected(@Param("userId") Long userId); | ||
|
|
||
|
|
@@ -124,6 +125,7 @@ AND b.end_at < NOW() | |
| LEFT JOIN rivals r ON b.fk_rival_id = r.id | ||
| WHERE (r.fk_first_user_id = :userId OR r.fk_second_user_id = :userId) | ||
| AND b.battle_status = 'PENDING' | ||
| ORDER BY b.created_at DESC | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| """, nativeQuery = true) | ||
| List<BattleJpaEntity> findPendingBattlesByUserId(@Param("userId") Long userId); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/main/java/com/process/clash/infrastructure/config/socket/SocketIoExceptionListener.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package com.process.clash.infrastructure.config.socket; | ||
|
|
||
| import com.corundumstudio.socketio.listener.DefaultExceptionListener; | ||
| import io.netty.channel.ChannelHandlerContext; | ||
| import lombok.extern.slf4j.Slf4j; | ||
|
|
||
| @Slf4j | ||
| public class SocketIoExceptionListener extends DefaultExceptionListener { | ||
|
|
||
| @Override | ||
| public boolean exceptionCaught(ChannelHandlerContext ctx, Throwable e) throws Exception { | ||
| // Upgrade 헤더가 없는 잘못된 요청(HTTP 등)이 올 때 발생하는 로그 제어 | ||
| if (e.getMessage() != null && e.getMessage().contains("not a WebSocket request")) { | ||
| log.warn("[Socket.IO] 비정상적인 연결 시도 차단: {} (IP: {})", | ||
| e.getMessage(), ctx.channel().remoteAddress()); | ||
| return true; // 에러 전파를 여기서 중단하여 불필요한 스택 트레이스 방지 | ||
| } | ||
| return super.exceptionCaught(ctx, e); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정렬 결과의 일관성(Determinism)을 보장하기 위해
id와 같은 고유한 값을 보조 정렬 키로 추가하는 것이 좋습니다. 특히 페이징 처리가 나중에 추가될 경우, 동일한started_at값을 가진 레코드들의 순서가 보장되지 않으면 데이터 누락이나 중복 노출 문제가 발생할 수 있습니다. 또한, Native Query에서OR조건과ORDER BY를 함께 사용하면 데이터량이 많아질 때 성능 저하가 발생할 수 있으므로 관련 컬럼의 인덱스 전략을 확인해 보시기 바랍니다.