Conversation
In Node 23, offset time zone IDs are now supported by `Intl.DateTimeFormat`. This commit changes the polyfill to handle these IDs.
Collaborator
Author
|
I see the CI upgrade broke the cookbook, I'll remove the upgrade from this PR for the time being while I investigate that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3103 +/- ##
==========================================
+ Coverage 96.05% 96.71% +0.66%
==========================================
Files 21 21
Lines 9951 9951
Branches 1802 1807 +5
==========================================
+ Hits 9558 9624 +66
+ Misses 346 281 -65
+ Partials 47 46 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
CI change restored. |
justingrant
approved these changes
Apr 14, 2025
Collaborator
justingrant
left a comment
justingrant
left a comment
There was a problem hiding this comment.
Looks good, but why not upgrade to Node 23 while we're at it?
Collaborator
Author
|
I seemed to remember that we were sticking to the LTS version, but maybe I just made that up. Node 23.x sounds good to me! |
This is not needed at all. We can just import temporal.mjs in the one place in the Demitasse tests where we need a Temporal object. (One other place, it was imported unnecessarily; remove that.)
Also no reason to use a resolver here, which is an unstable Node API. Instead use --require to import the bundled polyfill, and --eval to create a global assert() function.
23.x is now the current Node version. We should run the CI on that version so it doesn't diverge too much from what is likely to be our local setup. Intl.DurationFormat is available in that release so we can remove one test from the ignore file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.