Polyfill: Fix type definition of Duration.toLocaleString#3101
Merged
Polyfill: Fix type definition of Duration.toLocaleString#3101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
=======================================
Coverage 96.05% 96.05%
=======================================
Files 21 21
Lines 9951 9951
Branches 1802 1802
=======================================
Hits 9558 9558
Misses 346 346
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The options argument of
Duration.toLocaleStringis incorrectly typed asIntl.DateTimeFormatOptionswhich is incorrect. For example this code fails typechecking:TypeScript's lib.d.ts does not yet include type definitions for Intl.DurationFormat, so I've added the relevant options manually. This can be removed once TypeScript has shipped support.