Revert removal of codeString from HostEnsureCanCompileStrings#17
Merged
koto merged 1 commit intotc39:masterfrom May 7, 2024
Merged
Revert removal of codeString from HostEnsureCanCompileStrings#17koto merged 1 commit intotc39:masterfrom
koto merged 1 commit intotc39:masterfrom
Conversation
b291785 to
3bc677e
Compare
3bc677e to
488b6fd
Compare
Contributor
Author
|
@nicolo-ribaudo or @koto could you merge this please? |
Member
Summary of the updateIn the 2024-04 TC39 meeting we decided to not expose the built string to the host, under the assumption that that string was spec-internal only. Our recommendation was that instead the host should re-concatenate the string pieces to build its own representation of the string. It turns out however that the concatenated string was already exposed to users, through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for removal was based on a misunderstanding of the status quo (See tc39/ecma262#3294 (comment)).
I think this is okay to add back to the proposal document before we officially tell Tc39 in June?