add new lints matching some ECMA-262 editorial conventions#693
Merged
Conversation
5813558 to
81e8fcb
Compare
bakkot
reviewed
Apr 10, 2026
bakkot
approved these changes
Apr 10, 2026
Member
bakkot
left a comment
There was a problem hiding this comment.
These seem like they might have false positives, but if you've run it against 262, 402, and Temporal with no false positives it's fine to land and we can go back and relax any annoying ones later.
Not totally sure all of these should be confined to algorithms, though.
Member
Author
|
I ran it against 262, hence tc39/ecma262#3805. Haven't run it against 402 or any other specs yet, but I imagine it will just discover changes we actually want to make. |
nicolo-ribaudo
approved these changes
Apr 17, 2026
Co-authored-by: Nicolò Ribaudo <nribaudo@igalia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I used AI in the process of creating this PR.