Meta: use gh-action-mutex in the pr-preview action#3821
Merged
Conversation
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3821 and as multiple pages at https://tc39.es/ecma262/pr/3821/multipage . |
Member
Author
|
Alternatively, I guess we could make the job rebase and try to push again? There'd still be a race condition though. If we wanted to take a combined approach, we could just acquire the mutex for that push/rebase loop. |
bakkot
approved these changes
Apr 9, 2026
Member
bakkot
left a comment
bakkot
left a comment
There was a problem hiding this comment.
Assuming this works as described, sure
Member
Author
|
I don't have a great way to test it without a bunch of noise. But we should know pretty quickly whether it works or not after merging. |
michaelficarra
added
the
ready to merge
ljharb
force-pushed
the
publish-action-mutex
branch
from
10f526b to
2314d2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will avoid the problem where the PR preview push to gh-pages fails when multiple PRs are running through CI at the same time. Now they will queue up and run in sequence.