Editorial: fix error in String.prototype.endsWith note#3812
Merged
Conversation
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3812 and as multiple pages at https://tc39.es/ecma262/pr/3812/multipage . |
linusg
approved these changes
Apr 9, 2026
Member
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
I don't think this note is very useful, FWIW.
nicolo-ribaudo
approved these changes
Apr 9, 2026
Member
Author
|
@linusg I agree. Let's remove it in a separate PR. |
michaelficarra
added
the
ready to merge
Member
|
why fix it if it'll just be removed? |
Member
Author
|
@ljharb For historical reasons. If you look back at the thing that was removed (or want to revert the removal), it won't have an error in it. |
ljharb
force-pushed
the
string-endsWith-note
branch
from
66862b5 to
477ed18
Compare
Member
Author
|
Follow-up: #3831 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.