Skip to content

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbuckton wants to merge 94 commits into
base: main
Choose a base branch
from
+1,300 −44
Open

Add using and await using Declarations, SuppressedError, DisposableStack, and AsyncDisposableStack #3000

Changes from all commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
ca23022
Spec text for proposal-explicit-resource-management
rbuckton Jan 23, 2023
1080a47
Fix lint errors
rbuckton Jan 23, 2023
bd2c060
Run formatter
rbuckton Jan 23, 2023
218c551
Fix signature for DisposeResources
rbuckton Jan 23, 2023
7e4fefc
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
b9ab116
Fixes for some esmeta warnings
rbuckton Jan 23, 2023
6a4c0f1
Add missing ReturnIfAbrupt in DisposableStack.prototype.use
rbuckton Jan 23, 2023
280dd18
More ecmarkup signature fixes
rbuckton Jan 23, 2023
2417687
Change DisposeResources signature to return completion record
rbuckton Jan 24, 2023
0328275
Order sections by property name
jmdyck Jan 24, 2023
9fc423d
Syntax of types
jmdyck Jan 24, 2023
6eaff65
id of AO clause doesn't need to include param names
jmdyck Jan 24, 2023
db8c5c1
Avoid the use of `Type()`
jmdyck Jan 24, 2023
16b7408
Use preamble conventions from PR #2592
jmdyck Jan 24, 2023
5f0e964
Interface names are put in `<i>` rather than `<em>`
jmdyck Jan 24, 2023
b386bee
A 'Slots' table should have a 'Type' column
jmdyck Jan 24, 2023
4bbe20a
Add 'UsingDeclaration' to Annex A
jmdyck Jan 24, 2023
7873fce
misc minor fixes
jmdyck Jan 24, 2023
8e52125
add description suggestion from @jmdyck
rbuckton Jan 25, 2023
1e7d220
Add DisposeCapabilityRecord from tc39/proposal-explicit-resource-mana…
rbuckton Jan 25, 2023
0fc8741
Wrap UpdateEmpty calls in calls to Completion
rbuckton Jan 25, 2023
ed39b25
Run formatter
rbuckton Jan 25, 2023
55ca724
Run formatter again
rbuckton Jan 25, 2023
298a954
Fix formatting and capitalization
rbuckton Jan 26, 2023
b240820
Clean up DisposeResources signature, replace UpdateEmpty with assertions
rbuckton Jan 26, 2023
1dc4ace
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
78ad1d8
Use CreateBuiltinFunction
rbuckton Jan 29, 2023
171addb
Address additional editor feedback (from async PR)
rbuckton Jan 30, 2023
88fa3fa
Move BindingPattern restriction for 'using' to an early error
rbuckton Jan 30, 2023
f5f44d3
Fix typo in using declaration early errors
rbuckton Jan 30, 2023
1a612ca
Fix typos
rbuckton Jan 30, 2023
41712d3
run formatter
rbuckton Jan 30, 2023
b4473b2
Remove InstallErrorCause from SuppressedError, per 2023-jan consensus
rbuckton Jan 31, 2023
2715a18
Spec text for proposal-async-explicit-resource-management
rbuckton Jan 27, 2023
295c2a0
Run formatter
rbuckton Jan 27, 2023
33eaf4d
Add 'either' in front of 'null or undefined'
rbuckton Jan 29, 2023
69784e7
Address editor feedback
rbuckton Jan 29, 2023
de7df07
Address additional editor feedback
rbuckton Jan 30, 2023
51314f7
Switch back to a production parameter, update ASI note
rbuckton Mar 22, 2023
873cdff
Remove 'await' restriction per March 2023 consensus. See tc39/proposa…
rbuckton Mar 27, 2023
ec78dfb
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 20, 2024
6a187a2
Adopt consensus changes from tc39/proposal-explicit-resource-manageme…
rbuckton Mar 21, 2024
c7bad01
Adopt typo fix from tc39/proposal-explicit-resource-management#217
rbuckton Mar 21, 2024
b4b6045
Fix typos and add temporary PR note
rbuckton Mar 22, 2024
a5a4aaa
Remove temporary PR note
rbuckton Mar 22, 2024
acf7e17
Remaining consensus updates from proposal repo
rbuckton Mar 22, 2024
3ac77bc
Add missing undefined check in GetDisposeMethod
rbuckton Mar 22, 2024
358c618
Fix DisposeCapability leak
rbuckton Mar 25, 2024
3e231fe
fix formatting
rbuckton Mar 25, 2024
4f19a22
Switch to empty list
rbuckton Apr 10, 2024
8f3ac8c
Update text of NOTE
rbuckton Apr 10, 2024
edb1b27
Add PromiseCapability wrapper around sync dispose in an `await using`
rbuckton Apr 10, 2024
979ea3d
Fix missing lookahead restriction
rbuckton Mar 22, 2024
dce6060
Remove superfluous ClassBody restriction
rbuckton Mar 22, 2024
9739718
Add entries to esmeta-ignore
rbuckton May 24, 2024
144a9e1
Reduce unnecessary Awaits for nullish values in blocks containing `aw…
rbuckton Jun 15, 2024
262ed40
Add missing 'constructor' definitions
rbuckton Jan 8, 2025
45c337b
Disallow using/await using in a switch case/default clause
rbuckton Mar 28, 2025
36228a2
Fix formatting
rbuckton Mar 28, 2025
d590511
PR feedback
rbuckton Feb 27, 2026
59a9512
minor fixes
rbuckton Feb 27, 2026
d6dca82
Switch from @@ to % in a few more places
rbuckton Feb 27, 2026
61f6df1
Update esmeta-ignore.json
rbuckton Feb 27, 2026
43cf487
Update asyncDispose to be an async method
rbuckton Feb 27, 2026
8205f71
avoid threading kind through all the InitializeBinding machinery
bakkot Mar 8, 2026
0166a1f
rename _kind_ to _declarationKind_ in ForIn/OfBodyEvaluation
bakkot Mar 8, 2026
6aa5a27
move _declarationKind_ into the branch where that makes sense
bakkot Mar 8, 2026
2544000
move it back
bakkot Mar 8, 2026
c60bf06
PR Feedback
rbuckton Mar 11, 2026
a110211
Some missing changes pulled from rbuckton/ecma262#11
rbuckton Mar 11, 2026
34b715f
Fix some remaining suggestions from rbuckton/ecma262#7
rbuckton Mar 11, 2026
30b14de
Switch to <em> where appropriate
rbuckton Mar 11, 2026
c4ee347
PR feedback
rbuckton Mar 12, 2026
80aa02c
Don't overwrite completion parameter in DisposeResources
rbuckton Apr 12, 2026
a1cfb2e
The spec usually uses lower-case for ids.
jmdyck Mar 16, 2026
d9daf05
Drop 'variants' attribute
jmdyck Mar 16, 2026
ccd3e6e
Changes to Annex A to make it parallel to main-body grammar
jmdyck Mar 16, 2026
a62725e
Add subclauses to "Constructor Properties of The Global Object"
jmdyck Mar 17, 2026
913a7ab
Need to define ForDeclarationBindingInitialization for ForDeclaration
jmdyck Mar 20, 2026
eae38f7
Remove unreachable SDO rules
jmdyck Mar 20, 2026
63fc160
Remove more unreachable SDO rules
jmdyck Mar 20, 2026
52b7824
Remove unnecessary steps in CreateDisposableResource
jmdyck Mar 20, 2026
6398eb5
Add explicit return to algorithm
jmdyck Mar 20, 2026
cec53c1
EvaluateClassStaticBlockBody: add an Assert
jmdyck Mar 20, 2026
d099877
Remove 'kind' description from InitializeBinding
rbuckton Apr 16, 2026
5d774cc
CaseBlock can't have resources, so just assert
rbuckton Apr 16, 2026
049098f
Restore missing NOTE and fix indentation
rbuckton Apr 16, 2026
c6d343a
ContainsUsing and HasUnterminatedUsingDeclaration are identical
rbuckton Apr 16, 2026
2dabe4d
Rename V to value and O to obj
rbuckton Apr 27, 2026
878e362
Use list shorthand for NewDisposeCapability
rbuckton Apr 27, 2026
7f56768
Rely on NOTE rather than overwriting [[DisposableResourceStack]]
rbuckton Apr 30, 2026
e9ac02b
Add type to clauses and use 'this method'
rbuckton Apr 30, 2026
5bbd5a1
Merge branch 'main' into explicit-resource-management
rbuckton May 4, 2026
bc71ada
Revert changes to esmeta-ignore.json
rbuckton May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading