Skip to content

Fix CI #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tartley merged 2 commits into from
Jul 7, 2025
+2 −1
Merged

Fix CI #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51a1e58
no-op README change
tartley Mar 14, 2025
28a9513
Match Py3.7's available minor version
tartley Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- {python-version: "pypy-2.7", toxenv: "pypy"}
- {python-version: "pypy-3.8", toxenv: "pypy3"}
- {python-version: "2.7", toxenv: "py27"}
- {python-version: "3.7", toxenv: "py37"}
- {python-version: "3.7.17", toxenv: "py37"}

@hugovk hugovk Jul 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems this is what causes Unexpected value '', because we would also need to change "3.7" to "3.7.17" on line 14.

That fixes the syntax error and means the job will start, but then fails like:

  Version 3.7.17 was not found in the local cache
  Error: The version '3.7.17' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

https://github.com/hugovk/colorama/actions/runs/16121812976/job/45489220430

Alternatively, change them both back to "3.7" and it fails like:

  Version ~3.7.0-0 was not found in the local cache
  Error: The version '3.7' with architecture 'x64' was not found for Ubuntu 24.04.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

3.7 has been EOL for two years though, and I'm not personally interested in putting effort into it supporting, but I'm happy to help either drop support for it (my preference), or remove it from the CI matrix.

See https://github.com/hugovk/pypi-tools/blob/main/charts.md#colorama which shows there are very few installs for 3.7 and older.

@tartley tartley Jul 7, 2025

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we could drop support on main, and when the next release happens we'll bump the major version.

@hugovk hugovk Jul 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see PR #409.

- {python-version: "3.8", toxenv: "py38"}
- {python-version: "3.9", toxenv: "py39"}
- {python-version: "3.10", toxenv: "py310"}
Expand Down
1 change: 1 addition & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,3 +412,4 @@ See the CHANGELOG for more thanks!
to include Python 3.3 and 3.4
* Andy Neff for fixing RESET of LIGHT_EX colors.
* Jonathan Hartley for the initial idea and implementation.