Skip to content

refactor: shrink SBuiltinFuncDefinition to reduce binary size by 17MB… #35322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanshengliang wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −3
Open

refactor: shrink SBuiltinFuncDefinition to reduce binary size by 17MB… #35322

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00eedd8
refactor: shrink SBuiltinFuncDefinition to reduce binary size by 17MB…
guanshengliang May 12, 2026
b2f016a
refactor: remove dead codes
guanshengliang May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions source/libs/function/inc/builtins.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ typedef int32_t (*FCreateMergeFuncParameters)(SNodeList* pRawParameters, SNode*
typedef EFuncDataRequired (*FFuncDynDataRequired)(void* pRes, SDataBlockInfo* pBlocInfo);
typedef EFuncReturnRows (*FEstimateReturnRows)(SFunctionNode* pFunc);

#define MAX_FUNC_PARA_NUM 16
#define MAX_FUNC_PARA_FIXED_VALUE_NUM 16
#define MAX_FUNC_PARA_PATTERN_NUM 2
#define MAX_FUNC_INPUT_PARA_NUM 8
#define MAX_FUNC_PARA_FIXED_VALUE_NUM 8
Comment on lines +33 to +35
Comment on lines +33 to +35
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These new macros act as magic numbers. To improve maintainability, please add comments explaining why these specific values were chosen. This context will be valuable for anyone modifying this code in the future.

Suggested change
#define MAX_FUNC_PARA_PATTERN_NUM 2
#define MAX_FUNC_INPUT_PARA_NUM 8
#define MAX_FUNC_PARA_FIXED_VALUE_NUM 8
#define MAX_FUNC_PARA_PATTERN_NUM 2 // Max parameter patterns per function. Currently 1 is used, 2 allows for future extension.
#define MAX_FUNC_INPUT_PARA_NUM 8 // Max parameter descriptors per pattern. `_irate_partial` uses 4.
#define MAX_FUNC_PARA_FIXED_VALUE_NUM 8 // Max fixed values for a parameter. `week` function uses 8.



typedef struct SParamRange {
Expand All @@ -57,7 +58,7 @@ typedef struct SFunctionParaInfo {
int8_t minParamNum;
int8_t maxParamNum;
uint8_t paramInfoPattern;
SParamInfo inputParaInfo[MAX_FUNC_PARA_NUM][MAX_FUNC_PARA_NUM];
SParamInfo inputParaInfo[MAX_FUNC_PARA_PATTERN_NUM][MAX_FUNC_INPUT_PARA_NUM];
SParamInfo outputParaInfo;
} SFunctionParaInfo;

Expand Down
Loading