Skip to content

Support MSC3916 (without MSC3911)#509

Merged
turt2live merged 51 commits intomainfrom
travis/msc3916-only
Jul 3, 2024
Merged

Support MSC3916 (without MSC3911)#509
turt2live merged 51 commits intomainfrom
travis/msc3916-only

Conversation

@turt2live
Copy link
Copy Markdown
Member

@turt2live turt2live commented Nov 25, 2023

MSC3911 adds complexity that shouldn't block this feature.

See matrix-org/matrix-spec-proposals#3916
See #465
Closes #103
Closes #266
Closes #118

TODO:

  • MSC3916 - Split endpoints into Client-Server and Federation APIs
  • MSC3916 - X-Matrix authentication on Federation APIs
  • MSC3916 - Access token authentication on Client-Server APIs
  • MSC3916 - multipart/mixed Content-Type on new /download and /thumbnail endpoints
  • MSC3916 - Use new endpoints to download media
  • MSC3916 - Tests

}

log.Printf("[HTTP] [Auth=%s] [Host=%s] %s %s", c.AccessToken, c.ServerName, req.Method, req.URL.String())
log.Printf("[HTTP] [Auth=%s] [Host=%s] %s %s", req.Header.Get("Authorization"), c.ServerName, req.Method, req.URL.String())

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

[Sensitive data returned by HTTP request headers](1) flows to a logging call.
@turt2live turt2live force-pushed the travis/msc3916-only branch 3 times, most recently from 5b49457 to 17a78d5 Compare May 25, 2024 00:33
@turt2live turt2live marked this pull request as ready for review May 29, 2024 23:30
@turt2live turt2live force-pushed the travis/msc3916-only branch from 3d752e8 to b15f04a Compare June 20, 2024 22:27
Comment thread matrix/server_discovery.go Fixed
Comment thread api/_routers/97-require-server-auth.go Fixed
Comment thread matrix/requests.go Fixed
Comment thread matrix/server_discovery.go Fixed
@turt2live turt2live force-pushed the travis/msc3916-only branch from 805e500 to 69ac7b9 Compare July 2, 2024 21:00
@turt2live
Copy link
Copy Markdown
Member Author

I'm giving up trying to fix the tests here: #589

@turt2live turt2live merged commit 1c834ea into main Jul 3, 2024
@turt2live turt2live deleted the travis/msc3916-only branch July 3, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement MSC1902 Sign remote media requests Start implementation for media repo auth (MSC701)

2 participants