Skip to content

fix(shield): gate host OpenShift SCC privileged fields on .Values.host.privileged #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwardArchive wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −3
Open

fix(shield): gate host OpenShift SCC privileged fields on .Values.host.privileged #2625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/shield/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ maintainers:
- name: mavimo
email: marcovito.moscaritolo@sysdig.com
type: application
version: 1.37.1
version: 1.37.2
appVersion: "1.0.0"
4 changes: 2 additions & 2 deletions charts/shield/templates/host/openshift-securitycontextconstraint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ allowHostIPC: false
allowHostNetwork: true
allowHostPID: true
allowHostPorts: {{ or .Values.features.posture.host_posture.enabled (dig "prometheus_exporter" "enabled" false .Values.host.additional_settings) (dig "kspm_analyzer" "enabled" false .Values.host.additional_settings) }}
allowPrivilegeEscalation: true
allowPrivilegedContainer: true
allowPrivilegeEscalation: {{ .Values.host.privileged }}
allowPrivilegedContainer: {{ .Values.host.privileged }}
{{- if .Values.host.privileged }}
allowedCapabilities: []
{{- else }}
Expand Down
31 changes: 31 additions & 0 deletions charts/shield/tests/host/openshift-securitycontextconstraint_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,37 @@ tests:
path: allowedCapabilities
value: []

- it: SecurityContextConstraints allowPrivilegeEscalation/allowPrivilegedContainer are true when host.privileged is true
capabilities:
apiVersions:
- security.openshift.io/v1
set:
host:
privileged: true
asserts:
- equal:
path: allowPrivilegeEscalation
value: true
- equal:
path: allowPrivilegedContainer
value: true

- it: SecurityContextConstraints allowPrivilegeEscalation/allowPrivilegedContainer are false when host.privileged is false
capabilities:
apiVersions:
- security.openshift.io/v1
set:
host:
privileged: false
driver: universal_ebpf
asserts:
- equal:
path: allowPrivilegeEscalation
value: false
- equal:
path: allowPrivilegedContainer
value: false

- it: SecurityContextConstraints allowedCapabilities is not empty when host.privileged is false
capabilities:
apiVersions:
Expand Down
Loading