Skip to content

fix(shield): gate cluster OpenShift SCC privileged fields on run mode #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EdwardArchive wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shield): gate cluster OpenShift SCC privileged fields on run mode #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/shield/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ maintainers:
- name: mavimo
email: marcovito.moscaritolo@sysdig.com
type: application
version: 1.37.1
version: 1.37.2
appVersion: "1.0.0"
5 changes: 3 additions & 2 deletions charts/shield/templates/cluster/openshift-securitycontextconstraint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ allowHostIPC: false
allowHostNetwork: true
allowHostPID: true
allowHostPorts: {{ .Values.cluster.host_network }}
allowPrivilegeEscalation: true
allowPrivilegedContainer: true
{{- $clusterPrivileged := not (include "cluster.is_single_process_mode" .) }}
allowPrivilegeEscalation: {{ $clusterPrivileged }}
allowPrivilegedContainer: {{ $clusterPrivileged }}
allowedCapabilities: []
defaultAddCapabilities: []
fsGroup:
Expand Down
41 changes: 41 additions & 0 deletions charts/shield/tests/cluster/openshift-securitycontextconstraint_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,44 @@ tests:
- equal:
path: allowHostPorts
value: true

- it: SecurityContextConstraints - allowPrivilegeEscalation/allowPrivilegedContainer are true in default (multi-process) mode
capabilities:
apiVersions:
- security.openshift.io/v1
asserts:
- equal:
path: allowPrivilegeEscalation
value: true
- equal:
path: allowPrivilegedContainer
value: true

- it: SecurityContextConstraints - allowPrivilegeEscalation/allowPrivilegedContainer are false in single-process mode
capabilities:
apiVersions:
- security.openshift.io/v1
set:
cluster:
run_mode: single-process
asserts:
- equal:
path: allowPrivilegeEscalation
value: false
- equal:
path: allowPrivilegedContainer
value: false

- it: SecurityContextConstraints - allowPrivilegeEscalation/allowPrivilegedContainer are false on GKE Autopilot
capabilities:
apiVersions:
- security.openshift.io/v1
values:
- ../values/gke-autopilot.yaml
asserts:
- equal:
path: allowPrivilegeEscalation
value: false
- equal:
path: allowPrivilegedContainer
value: false
Loading