Draft: Align with mainline at fc566d74005a4aefbe125b9b2f777d9514c60c87 - #27
Open
en-sc wants to merge 628 commits into
Open
Draft: Align with mainline at fc566d74005a4aefbe125b9b2f777d9514c60c87#27en-sc wants to merge 628 commits into
en-sc wants to merge 628 commits into
Conversation
Move the configuration files into a dedicated vendor folder as required by the developer guidelines. Change-Id: I9ed39e32b6281a9cb8510914690f3f7751b795c8 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9271 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
This matches the behaviour of code which calls LOG_DEBUG_IO etc. instead. Change-Id: I7679f0fc67222f947a4d0f1d53aa627a186ebcd3 Signed-off-by: R. Diez <rdiez-2006@rd10.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9318 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Wrap the name field in braces when formatting the flash list Tcl structure so that Tcl does not interpret backslash escape sequences. This ensures Windows paths are preserved verbatim in the output and can be reliably matched in Tcl scripts. Fixes: 80fc9fa ("flash: nor: rewrite command 'flash list' as COMMAND_HANDLER") Change-Id: Ibd0a4b292828f084122e4a02732dc69ac0885f3c Signed-off-by: HAOUES Ahmed <ahmed.haoues@st.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9360 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
The flash driver 'stm32l4x' supports the device STM32WBA too. Add it in the list of supported devices. Change-Id: I5e2ba0c9ea198eb22d1bd329dd932bc0b1b3e886 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9392 Reviewed-by: Marc Schink <dev@zapb.de> Tested-by: jenkins Reviewed-by: Ahmed Haoues <ahmed.haoues@st.com>
Update fsize_addr parameter to reference non-secure memory address Change-Id: I5098f478169bfaac726b96b071b99ca63d25d531 Signed-off-by: HAOUES Ahmed <ahmed.haoues@st.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9357 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
The function add_service() can return on error when cannot create the new service. In this case the caller cannot assume that the parameter 'priv' has been taken in consideration and it should take care of free() it. To avoid a double free(), add_service() should not free() the parameter 'priv' if it exits with error. Replace the call to free_service() with a dedicated exit path on error. Change-Id: I340ec3ee46f471f31170c6717ed74fb632f0da20 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reported-by: Karl Palsson <karlp@tweak.au> Fixes: 171454f ("server: fix a new double free()") Fixes: 5ff384b ("semihosting: fix memory leak and double free") Reviewed-on: https://review.openocd.org/c/openocd/+/9372 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
When add_service() fails, the caller has to free() the private data. Add the missing free(). Change-Id: I998782ad3a2612dd289e269e889a3c6912fd8461 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9373 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
During GDB service start, check that memory is properly allocated and if add_service() fails release the allocated memory. While there, modify the code following the coding style. Change-Id: Iebd1481a82f7391c110c5f6ad9878ba4abf052b3 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9374 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
During JSP service start, check that memory is properly allocated and if add_service() fails release the allocated memory. Change-Id: I7eb2ea8a10dbeccd27fd39485080552c5d0736d3 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9375 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
The function free_service() does not close the TCL socket when the service is shutdown. Add the necessarily code. Change-Id: I58c5c4fee3111949fcc143c6226522c29d976493 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9376 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Ensures proper rendering on GitHub [1] / GitLab, clarifies that Markdown syntax is expected from contributors, and enables editor syntax highlighting. [1] https://github.com/openocd-org/openocd Change-Id: Icaff52ed2bf7d6f32b5812b5aff1c081e8b7507a Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9388 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Refurbish the document and use only Markdown syntax according to the specification in [1]. [1] https://www.markdownguide.org/ Change-Id: I7baa9a25621155ff4acabcfde724f233578c9ee1 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9390 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Refurbish the document and use only Markdown syntax according to the specification in [1]. [1] https://www.markdownguide.org/ Change-Id: I7ef0d4b7359ba12fd6f2fbf2c4ea1d092dcd71bd Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9391 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
Document the OpenOCD installation with specific examples for package managers and move the installation section to the beginning of the document to make it more prominent. Change-Id: I86e175fdd4060b49070a5c8d2b92ec1c6cfe6acf Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9395 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Refactor the document structure to avoid multiple top-level headings in the same file. The document is now free of Markdown linter [1] errors. [1] https://github.com/jackdewinter/pymarkdown Change-Id: I70122453c23c6230617c72d45986c88bb646edf5 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9402 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Refactor the document structure to align with README.Windows and fix two line-length issues so that the file is free of Markdown linter [1] errors. [1] https://github.com/jackdewinter/pymarkdown Change-Id: Iab5ca09aeed2225e43934c8c2bd952a3a4b32cd0 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9403 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Adjust Markdown formatting to satisfy the Markdown linter [1], no content changes are included. [1] https://github.com/jackdewinter/pymarkdown Change-Id: I28a2e8d12bfab08017de330ae3e81239082110ff Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9404 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Previously, configure.ac only checked whether glibc was available, but other C runtime libraries like Newlib have mallinfo too. This is a first step to remove configuration option --enable-malloc-logging and replace it with a debug level configurable at runtime. Change-Id: If30fc98a84158459e222fddf08043f46d6fa4112 Signed-off-by: R. Diez <rdiez-2006@rd10.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9394 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
Like for Cortex-M7, also Cortex-M85 prevents detecting the cache properties when the CPU is kept under reset. Extend to Cortex-M85 the same deferred mechanism already in place for Cortex-M7. Change-Id: Id274bb6c0b46c568554eed9671ef690c34cf7cfa Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9397 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Reviewed-by: Marc Schink <dev@zapb.de>
The incremental counter of logged lines is a signed int. Change it to unsigned, since negative values has no sense in this context. Change-Id: Ia75f9ca038bba385c5f88fb9fa368faaf055f9a3 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9401 Reviewed-by: R. Diez <rdiez-2006@rd10.de> Tested-by: jenkins
The 'dap info' command was not checking that the target was an ARM before dereferencing the `arm` pointer. This would cause a crash if the current target was (say) a mem_ap. Add 'target_to_dap' function to safely get the dap Change-Id: I0c765f915f2ef7b9a7d20c934e144559ca4e5f1c Signed-off-by: Grant Ramsay <grant.ramsay@hotmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/8415 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
- Boya-Micro BY25Q128AS: 16 MB - Byte-Semi BY25Q16ES: 2MB Change-Id: Ib3caee62abc34f92321425d9427054b6a9b6ec66 Signed-off-by: Gennaro Tortone <gtortone@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9412 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
.editorconfig is supported out-of-the box by many editors (vim, vscode, etc...). This file prevent new comers to do mistake with their editor configuration. Change-Id: I60c3dedc20161883f388af6f1cb9b95b90beff2a Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9454 Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
1. Added comments like /* MSPM0G310x-Q1 */ to the parts table based on the datasheet the parts came from. 2. Sorted the MSPM0G310x-Q1 device lines alphabetically: this is how all other MSPM0G parts are organized. Change-Id: I90d0f44289a538667c4ad0f23d44581f3c65d0c8 Signed-off-by: Mikhail Iakhiaev <iakhiaev@google.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9419 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Reviewed-by: Nishanth Menon <nm@ti.com>
Neither "MSPM0G3505TDGS28R" nor its variant number 0xdf is listed in the MSPM0G3505 datasheet (likely removed): Link: https://www.ti.com/lit/ds/symlink/mspm0g3505.pdf#page=75 Change-Id: I3828744a91477b3e3fd164055aa0fe068483f87d Signed-off-by: Mikhail Iakhiaev <iakhiaev@google.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9420 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Reviewed-by: Nishanth Menon <nm@ti.com>
1. Added some missing variants for MSPM0G110x and MSPM0G150x parts. 2. Corrected the variant number for "MSPM0G1106TRHBR", according to datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g1106.pdf#page=68 3. Added MSPM0G350x-Q1 devices. Datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g3507-q1.pdf#page=77 Change-Id: Id4a14b284a5d032d140d695674d1912cbe87d7f6 Signed-off-by: Mikhail Iakhiaev <iakhiaev@google.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9417 Tested-by: jenkins Reviewed-by: Nishanth Menon <nm@ti.com> Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Added support for the following parts: * MSPM0Gx51x, datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g3518.pdf#page=101 * MSPM0G351x-Q1, datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g3518-q1.pdf#page=99 * MSPM0G3529-Q1, datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g3529-q1.pdf#page=92 * MSPM0G5187, datasheet: Link: https://www.ti.com/lit/ds/symlink/mspm0g5187.pdf#page=87 Note, these parts have different "part_num" values than the pre-existing MSPM0G parts listed in this file. Tested by successfully programming (and verifying) an image onto LP-MSPM0G3519 development board. Change-Id: I15f3b368f5307661a32953074768ba810412cf0a Signed-off-by: Mikhail Iakhiaev <iakhiaev@google.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9418 Tested-by: jenkins Reviewed-by: Nishanth Menon <nm@ti.com> Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
The MSPM0 devices support only SWD. Drop swj support, add swd support. This also gets rid of the following warnings: Warn : DEPRECATED: auto-selecting transport "swd". Use 'transport ... Warn : Transport "swd" was already selected Tested by programming/verifying firmware on LP-MSPM0G3519 dev board. Change-Id: Ieafd9c4691343124b2dfb2daa1c0d3a96b13e485 Signed-off-by: Mikhail Iakhiaev <iakhiaev@google.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9413 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Return directly the error code returned by last called function instead of handling it. Change-Id: I967deb348db535de1972056021484f0e7f32df1c Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9385 Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins Reviewed-by: Marc Schink <dev@zapb.de>
The functions in struct target_type::blank_check_memory() return either an OpenOCD error or a positive value that indicates the number of blocks checked. To prevent the mix of error codes and returned values, return the value through an additional parameter 'checked' and then return ERROR_OK. While there: - change to unsigned int the parameter 'num_blocks'; - in armv7m_blank_check_memory() verify that the working area can contain at least two 'algo_block'. Change-Id: Ie22f5816819bc77ec611c3f251373d026ed9f784 Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9386 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Add the prefix to makebin to match other commands. This fixes building, for example, on Fedora, which uses the 'sdcc' prefix for all SDCC commands. Change-Id: I93705062c58d2b7821e37bf9fa1b46aaf8648d1c Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9777 Reviewed-by: Adrien Charruel <adrien.charruel@gmail.com> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
When VTYPE is updated: - VL is set to some appropriate value - VSTART is set to zero Change-Id: If67d0e4a1058d35f47b42c67abc2183836f34f22 Signed-off-by: Anatoly Parshintsev <kupokupokupopo@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9414 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Writes to the vtype register are expected to have the side effect of resetting vl and vstart. However, the current implementation caches the vtype state on read, which prevents subsequent writes with already-cached values from being issued. Change-Id: I28beea6e2145bca52c5b37023399d6ae0937dfe0 Signed-off-by: Anatoly Parshintsev <kupokupokupopo@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9416 Tested-by: jenkins Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
vxrm and vxsat registers are mirrored in vcsr, so we can't cache any of them. Change-Id: I09760de5b76c330797caa99d2ef0ef151546e956 Signed-off-by: Anatoly Parshintsev <kupokupokupopo@gmail.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9422 Reviewed-by: Tomas Vanek <vanekt@fbl.cz> Tested-by: jenkins
Add target configuration for the Microchip SAMA7G5 series (Cortex-A7 based MPU). Supports both JTAG and SWD interfaces. Add board configuration for the SAMA7G54-EK evaluation kit. Link: https://www.microchip.com/en-us/product/sama7g54 Link: https://www.microchip.com/en-us/development-tool/EV21H18A Change-Id: I94085babaf1b2f4ce92a44ed900128fc6093f397 Signed-off-by: Frederic Boyer <frederic.boyer@microchip.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9524 Tested-by: jenkins Reviewed-by: zapb <dev@zapb.de> Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Add target configuration for the Microchip SAMA7D6 series (Cortex-A7 based MPU). Supports both JTAG and SWD interfaces. Add board configuration for the SAMA7D65 Curiosity board. Link: https://www.microchip.com/en-us/product/sama7d65 Link: https://www.microchip.com/en-us/development-tool/EV63J76A Change-Id: Ieda7658167e87c6f011b4c267d2598b80754e067 Signed-off-by: Frederic Boyer <frederic.boyer@microchip.com> Reviewed-on: https://review.openocd.org/c/openocd/+/9523 Tested-by: jenkins Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Reviewed-by: zapb <dev@zapb.de>
Tested on NUCLEO-U575ZI-Q development board. Change-Id: I5870c44b3a7e5e48dc3d0a166734f116c32bfca3 Signed-off-by: Marc Schink <dev@zapb.de> Reviewed-on: https://review.openocd.org/c/openocd/+/9749 Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com> Tested-by: jenkins
Change-Id: I0b48208f937a0412bfae61f9fa3717418e730aa3 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
If you need to setup the hooks, please consult the [OpenOCD docs] on how to do so. [OpenOCD docs]: https://review.openocd.org/Documentation/user-changeid.html Change-Id: Ie7c4fbad11958a5abe40ec671393cd79041d8436 Change-Id: If5294a6a661ba1736f4fc744c181b1fee90c4547 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
The file is unused and is not tested. Change-Id: Ia358b9c8952dad42c22409f297a4964b017271dd Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
These files can be found in [1]. 1: https://review.openocd.org/c/openocd/+/9820 Change-Id: I6ce58db8d1a3ef1bf201c2b3a98339c31233233d Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
With the introduction of `oscan1_mode` the config is obsolite. See [1]. 1: https://review.openocd.org/c/openocd/+/6981 Change-Id: Ia1a69cb918f67227edf6a2ffcfb301fc7470d008 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
The reverted change is on review [1]. 1: https://review.openocd.org/c/openocd/+/9821 Change-Id: I9e7799cfaf3cc411675bad00b977f28949690881 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit 6ba66c9. The original changed lacked motivation. Change-Id: Ia90edd00baec6c7f1923457482c5872500b7da0c Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit c3a7441. The change lacks motivation. Change-Id: I24080ad6d46b5871ed992ced005f6ea9d3599470 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit 1c07a20. The original commit seems like an ad-hoc fix for an issue that is not present anymore. Change-Id: If3ab19663a848ef40bd69aca1ef0e3c2dcf8ab9c Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit 342ca4a. The patch is a part of a mainline review [1]. Checkpatch-ignore: SPDX_LICENSE_TAG 1: https://review.openocd.org/c/openocd/+/9822 Change-Id: I3c5476ede8e7759282474f6a4381a1ee58b8775d Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit c96a24a. The patch is a part of a mainline review [1]. 1: https://review.openocd.org/c/openocd/+/9822 Change-Id: Id2dad341173b9aa739bc5aa7d1dbdcd80f0c07b3 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit e8b0545. The original patch is on mainline review [1]. 1: https://review.openocd.org/c/openocd/+/9175 Change-Id: I4ec2ee8bad8662ea137684385475bad47723819c Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
The work on porting the FreeRTOS support on RISC-V from RISC-V fork can be found at [1]. Checkpatch-ignore: SPACING UNNECESSARY_PARENTHESES BRACES 1: https://review.openocd.org/c/openocd/+/9757 Change-Id: I65fc4d083c27647adb8a357f508584d5b93da8e2 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
This reverts commit f9af0b6. The original change is an ad-hoc solution to an issue that is not present anymore. Change-Id: I1358ddec8ac6abc7586f5de080d9e8851bfee321 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
The difference isn't worth the hustle of maintaining it. Change-Id: I57602be7f995a469c5d9aa2e32c79a3e4bb141d3 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
The difference does not introduce any failures with the RISC-V tests testsuite on Spike. Since the changes do not seem like improvements, drop them. Change-Id: I227b1096d1de1eb180d9d665fb3719caea1801a7 Signed-off-by: Evgeniy Naydanov <evgeniy.naydanov@syntacore.com>
Collaborator
Author
|
Testing results:
|
Change-Id: If0d30aaedb19d7c594a9f51dec37309138c816bd
This reverts commit 92e10ab.
| /** | ||
| * Reset the @c examined flag for the given target. | ||
| */ | ||
| static inline void target_reset_examined(struct target *target) |
There was a problem hiding this comment.
this duplicates definition on target.h
| &riscv_target, | ||
| &scr5_target, |
| @@ -686,7 +698,6 @@ int target_examine_one(struct target *target) | |||
| return retval; | |||
| } | |||
|
|
|||
| LOG_USER("[%s] Target successfully examined.", target_name(target)); | |||
There was a problem hiding this comment.
I think you've mentioned that this breaks openocd_run.exp . Can we keep this for now or adjust openocd launcher?
| LOG_ERROR("Target not examined yet"); | ||
| return ERROR_FAIL; | ||
| LOG_TARGET_ERROR(target, "not examined"); | ||
| return ERROR_TARGET_NOT_EXAMINED; | ||
| } | ||
| if (!target->type->checksum_memory) { |
There was a problem hiding this comment.
I think this part resolved merge conflict incorrectly. this early check is not in upstream. Could you double-check, please?
| @@ -1,17 +0,0 @@ | |||
| adapter driver ftdi | |||
There was a problem hiding this comment.
This is needed for Syntacore purposes.
en-sc
force-pushed
the
en-sc/allign-with-mainline
branch
from
August 5, 2026 10:53
6cd28e8 to
664aa26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits that revert cleanly
Changes that do not revert cleanly
Re-examine
Sections vs segments
Break on shutdown
GitHub CI
Submodules
Running target memory
Verify image
jtag exectute
SCR5
Syntacore tools
jtag execute