Skip to content

fix: polish widgets foundation#946

Merged
ovitrif merged 0 commit into
test/calculator-widget-testsfrom
fix/widgets-v61-936
May 18, 2026
Merged

fix: polish widgets foundation#946
ovitrif merged 0 commit into
test/calculator-widget-testsfrom
fix/widgets-v61-936

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented May 16, 2026 •
edited
Loading

Related: #950

Description

This PR is now superseded by #942.

The widget foundation polish originally carried here has been ported into #942 so reviewers can evaluate the calculator/widget polish in one place. This branch is intentionally aligned with #944 and should have no remaining diff.

Historical scope that moved to #942:

  1. Wide in-app widget previews by default.
  2. Facts OS widget tap-to-open behavior.
  3. OS widget reconfigure affordance for Price, Headlines, Blocks, and Weather.
  4. Edge-to-edge system bar styling on the OS widget configuration screen.
  5. Price widget formatting without duplicated currency symbols on non-US locales.

Preview

The original recordings remain attached here for context, but the implementation is now in #942.

Walkthrough Widget OS Settings
scrcpy.2026-05-18.005832.mp4
scrcpy.2026-05-18.005833.mp4

QA Notes

Manual Tests

N/A - superseded by #942.

Automated Checks

@ovitrif ovitrif changed the title fix: finish widget release fixes fix: polish widgets foundation May 16, 2026
@ovitrif ovitrif self-assigned this May 17, 2026
@ovitrif ovitrif added this to the 2.3.0 milestone May 17, 2026
@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch 2 times, most recently from 6c0433f to 3ce7ff0 Compare May 17, 2026 23:56
@ovitrif ovitrif requested review from jvsena42 and piotr-iohk May 18, 2026 00:20
@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch from 1327cec to c229d55 Compare May 18, 2026 01:12
@ovitrif ovitrif force-pushed the test/calculator-widget-tests branch 4 times, most recently from 836a65f to 61cc72c Compare May 18, 2026 08:15
@piotr-iohk
Copy link
Copy Markdown
Collaborator

piotr-iohk commented May 18, 2026

It would be good to resolve conflicts before test/review, so we’re checking the final mergeable state.

@ovitrif ovitrif mentioned this pull request May 18, 2026
Open
9 tasks
@ovitrif ovitrif linked an issue May 18, 2026 that may be closed by this pull request
Polish Widgets Foundation #936
Open
9 tasks
@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 18, 2026 •
edited
Loading

It would be good to resolve conflicts before test/review, so we’re checking the final mergeable state.

Yes, pls hold reviews. Re-drafted.

Was meant to be ready but then I changed some things in base PRs.

@ovitrif ovitrif marked this pull request as draft May 18, 2026 09:54
@ovitrif ovitrif removed request for jvsena42 and piotr-iohk May 18, 2026 09:55
@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch from c229d55 to 0977fb0 Compare May 18, 2026 10:02
@ovitrif ovitrif force-pushed the test/calculator-widget-tests branch from 61cc72c to 2637a68 Compare May 18, 2026 10:35
@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch 2 times, most recently from c5155ee to 9285b75 Compare May 18, 2026 11:44
@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 18, 2026 •
edited
Loading

Still fixing, found another issue when Calculator widget is above many widgets on home screen:

Calculator Numpad issue
Numpad is not at the bottom of the screen.

@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch 3 times, most recently from 47545d3 to a3e4b56 Compare May 18, 2026 12:35
@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 18, 2026

Will move the fixes for calculator widget to:

@jvsena42 jvsena42 mentioned this pull request May 18, 2026
Draft
35 tasks
@ovitrif ovitrif mentioned this pull request May 18, 2026
Open
@ovitrif ovitrif merged commit b45eeb4 into test/calculator-widget-tests May 18, 2026
@ovitrif ovitrif force-pushed the test/calculator-widget-tests branch from 2637a68 to b45eeb4 Compare May 18, 2026 13:34
@ovitrif ovitrif deleted the fix/widgets-v61-936 branch May 18, 2026 13:34
@ovitrif ovitrif force-pushed the fix/widgets-v61-936 branch from a3e4b56 to b45eeb4 Compare May 18, 2026 13:34
@ovitrif ovitrif mentioned this pull request May 18, 2026
Draft
8 tasks
@ovitrif
Copy link
Copy Markdown
Collaborator Author

ovitrif commented May 19, 2026 •
edited
Loading

This PR got auto-merged by GitHub (as mistake of agent's work) because its commit was cherry picked in its base PRs branch.
Afterwards I selectively extracted only the changes which were polishing the actual calculator behavior (see prev comments) and replayed those in #942.

cc. @jvsena42

New PR will open to re-propose the remaining changes for v61 widgets polishing, to close task:

The PR is currently a draft, until I validate it and record the preview videos again, on latest commit:

#942 included those by mistake but they've been extracted out of it meanwhile, to keep that PR focused on calculator widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ovitrif ovitrif

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

Polish Widgets Foundation

2 participants

@ovitrif @piotr-iohk