Skip to content

[git] Remove helm-gitignore from git layer#15127

Merged
smile13241324 merged 1 commit into
syl20bnr:developfrom
eklitzke:remove-helm-gitignore
Nov 2, 2021
Merged

[git] Remove helm-gitignore from git layer#15127
smile13241324 merged 1 commit into
syl20bnr:developfrom
eklitzke:remove-helm-gitignore

Conversation

@eklitzke
Copy link
Copy Markdown
Contributor

Related to #15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.

Related to syl20bnr#15117, this removes the helm-gitignore from the git layer because it
hasn't been updated to use the new git-modes package. The helm-gitignore
functionality isn't particularly useful anyway, it's just a utility to help
generate .gitignore files.

This change can be reverted if the upstream helm-gitignore package is fixed and
people find the functionality it provides to be useful.
Copy link
Copy Markdown
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smile13241324 smile13241324 merged commit 66e509f into syl20bnr:develop Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants