Skip to content

[lldb] Set return status in swift-healthcheck #12924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kastiglione wants to merge 2 commits into
base: swift/release/6.4.x
Choose a base branch
from
+5 −1
Open

[lldb] Set return status in swift-healthcheck #12924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46744fd
[lldb] Set return status in swift-healthcheck
kastiglione May 8, 2026
281eae9
Update TestSwiftHealthCheck.py
kastiglione May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lldb/source/Commands/CommandObjectHealthcheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#include "lldb/Host/HostInfo.h"
#include "lldb/Interpreter/CommandReturnObject.h"
#include "lldb/Utility/Log.h"
#include "lldb/lldb-enumerations.h"
#include "lldb/lldb-private.h"

#include "Plugins/Language/Swift/LogChannelSwift.h"
Expand Down Expand Up @@ -55,6 +56,8 @@ void CommandObjectHealthcheck::DoExecute(Args &args,

result.AppendMessageWithFormat("Health check written to %s\n",
temp_path.c_str());
result.SetStatus(lldb::eReturnStatusSuccessFinishResult);

#if defined(__APPLE__)
// When in an interactive graphical session and not, for example,
// running LLDB running over ssh, open the log file straight away in
Expand Down
3 changes: 2 additions & 1 deletion lldb/test/API/lang/swift/swift-healthcheck/TestSwiftHealthCheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ def test_run_healthcheck(self):
self, 'main')
self.expect("expression 1")
result = lldb.SBCommandReturnObject()
ret_val = self.dbg.GetCommandInterpreter().HandleCommand("swift-healthcheck", result)
ret_val = self.ci.HandleCommand("swift-healthcheck", result)
self.assertEqual(ret_val, lldb.eReturnStatusSuccessFinishResult)
log = result.GetOutput()[:-1].split(" ")[-1]
self.assertEqual(log[-4:], ".log")
import io, re
Expand Down