🍒 [lldb-dap][vscode][windows] check if Python is installed properly before starting lldb-dap (llvm#181124)#12909
Conversation
|
@swift-ci please test |
Implement [`[RFC] Add a Python check command to lldb-dap and lldb`](https://discourse.llvm.org/t/rfc-add-a-python-check-command-to-lldb-dap-and-lldb/88972). This patch adds the `--check-python` flag to `lldb-dap` on Windows, to allow dap clients to verify the correct Python version is available before trying to start `lldb-dap`. Depends on: - llvm#180786 rdar://165442474 (cherry picked from commit 8d34f28)
charles-zablit
force-pushed
the
charles-zablit/lldb-dap/vscode/windows/python-check-to-release-6.4.x
branch
from
781bff9 to
5297dd0
Compare
|
@swift-ci please test |
…ore starting lldb-dap (llvm#181124) (cherry picked from commit f93fc5e)
|
@swift-ci please test |
charles-zablit
force-pushed
the
charles-zablit/lldb-dap/vscode/windows/python-check-to-release-6.4.x
branch
from
5297dd0 to
ec5a598
Compare
|
@swift-ci please test macos |
| "Python is not installed correctly. Please install it to use lldb-dap.", | ||
| { | ||
| modal: true, | ||
| detail: pythonCheckProcess.stderr?.toString() ?? "", |
There was a problem hiding this comment.
does the stderr suggest a remedy? If not is there documentation published anywhere with minimum versions, etc? We sometimes over a notification button that when clicked opens documentation
There was a problem hiding this comment.
This is what it currently looks like:
In Swiftlang, we also have a note that's displayed explaining to the user which version of Python to install and where to get it:
llvm-project/lldb/source/Host/windows/PythonPathSetup/PythonPathSetup.cpp
Lines 106 to 119 in cf2f82f
It's printed as an llvm::note which goes to stderr. The modal window above will have that additional text.
2 participants
rdar://170221975