[lldb][test] Add embedded Swift test category#12862
Closed
Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Closed
[lldb][test] Add embedded Swift test category#12862Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Conversation
This adds a Swift test variant that run each Swift test with the test target compiled as embedded Swift.
Author
|
@swift-ci please test |
890cd5b to
310aa76
Compare
Author
|
@swift-ci please test |
Author
|
Closing in favour of the new #12926 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a embedded Swift test variant that automatically re-runs test in embedded Swift mode unless
a test explicitly disables this behaviour. It also adds the required
skipIfEmbeddedSwiftto disable any teststhat currently do not work in embedded Swift. This patch does not yet remove any potentially redundant embedded Swift tests.
How many tests have a passing embedded Swift variant?
About 33% (200) of the 584 Swift tests (1 test = 1
test_*method) pass with embedded Swift. It's hard to automatically classify the remaining failures but they range from LLDB crashing, to linker failures, to unavailable language features in embedded.I skipped everything without an explicit root cause attached for most tests. So for now a skip decorator that does not have a root-cause attached should be considered a potential bug.
By how much does the test suite runtime increase?
On my M4 Pro machine with 14 logical cores I get the following test timing increases:
It should be noted that we could now also remove several
embedded/tests so the actual test overhead of this could be lower than listed above. If we (optimistically) removed all potentially redundant embedded Swift tests we would save about 15 seconds of testing time. The numbers above change roughly to +4%/+10% test suite runtime overhead.