[lldb] Handle simulator printout in TestSimulatorPlatform (cherry-pick)#12857
Closed
Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Closed
[lldb] Handle simulator printout in TestSimulatorPlatform (cherry-pick)#12857Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Teemperor wants to merge 2 commits intoswiftlang:stable/21.xfrom
Conversation
This test invokes a binary in a simulator and then reads the first line of stderr to parse the PID of the invoked binary. This approach fails when the simulator itself prints a warning/error on startup. In this case, we try to parse the error as the PID and fail. This patch just removes the line limit. It doesn't seem to add any value as we anyway need to search until we find the PID line, and if there is no PID line we cannot do anything but time out eventually. See also rdar://169799464 (cherry picked from commit 918e446)
Author
|
@swift-ci please test |
Teemperor
changed the title
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes TestSimulatorPlatform.py failures on some host configurations.
cherry picked from commit 918e446
cherry picked from commit 93845b8