Skip to content

Fix socket fd leaks on AsyncSocket connect/accept failure paths - #227

Merged
swhitty merged 3 commits into
swhitty:mainfrom
ianegordon:ian/tvt-1077-asyncsocket-leaks-the-socket-fd-on-connectaccept-failure
Jul 22, 2026
Merged

Fix socket fd leaks on AsyncSocket connect/accept failure paths#227
swhitty merged 3 commits into
swhitty:mainfrom
ianegordon:ian/tvt-1077-asyncsocket-leaks-the-socket-fd-on-connectaccept-failure

Remove fd-count regression test

6508863
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 21, 2026 in 1s

92.85% (-0.04%) compared to 4e246d3

View this Pull Request on Codecov

92.85% (-0.04%) compared to 4e246d3

Details

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.85%. Comparing base (4e246d3) to head (6508863).

Files with missing lines Patch % Lines
FlyingSocks/Sources/AsyncSocket.swift 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   92.88%   92.85%   -0.04%     
==========================================
  Files          71       71              
  Lines        3727     3735       +8     
==========================================
+ Hits         3462     3468       +6     
- Misses        265      267       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.