Recognize test classes that inherit from a custom base class - #324
Merged
Conversation
Test discovery matched `class X: XCTestCase {` literally, so a class inheriting
from a shared base never reached the Testing panel. The scanner now reads the
first type in the inheritance clause and accepts any name from the new
`sweetpad.testing.baseClasses` setting, which also lets it tolerate protocol
conformances, generics and clauses wrapped across lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323. Test discovery matched
class X: XCTestCase {literally, so classes inheriting from a shared base never appeared in the Testing panel; it now reads the first type in the inheritance clause and accepts any name listed in the newsweetpad.testing.baseClassessetting. Matching stays textual, so a longer chain needs every level listed, and inherited test methods and Swift Testing remain out of scope.