Skip to content

feat(core): respect decoratorVersion config#956

Merged
Brooooooklyn merged 1 commit intomasterfrom
respect-decorator-versions
Aug 17, 2025
Merged

feat(core): respect decoratorVersion config#956
Brooooooklyn merged 1 commit intomasterfrom
respect-decorator-versions

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn merged commit 2dcaa95 into master Aug 17, 2025
16 checks passed
@Brooooooklyn Brooooooklyn deleted the respect-decorator-versions branch August 17, 2025 12:52
@MuTsunTsai
Copy link
Copy Markdown

No, this doesn't really close #939 nor #773, for a few reasons:

  1. It assigns parser.decorators to Boolean(opts.experimentalDecorators), which is wrong. It should be true always. Doing it the other way will make decorators available only for the legacy experimental decorators.
  2. It assings transform.decoratorVersion to opts.decoratorVersion, but the latter was never assigned in tsCompilerOptionsToSwcConfig so the whole thing just doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants