Skip to content

Fix go vet findings #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix go vet findings #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/personname/groupInfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ func validateGroupNullSepLevel(level GroupTrailingNullLevel) error {
// GroupInfo holds the parsed information for any one of these groups the person name
// groups specified in the DICOM spec:
//
// - Alphabetic
// - Ideographic
// - Phonetic
// - Alphabetic
// - Ideographic
// - Phonetic
type GroupInfo struct {
// FamilyName is the person's family or last name.
FamilyName string
Expand Down
2 changes: 1 addition & 1 deletion pkg/personname/info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func (info Info) MustDCM() string {
}

// IsEmpty returns whether the PN value contains any actual information. This method
// ignores separator, so both '' and '^^^^=^^^^=^^^^' would return true.
// ignores separator, so both "" and '^^^^=^^^^=^^^^' would return true.
func (info Info) IsEmpty() bool {
return info.Alphabetic.IsEmpty() &&
info.Ideographic.IsEmpty() &&
Expand Down
Loading