Return an error if Pixel Representation is signed and a signed native is pixel data value is found.#296
Open
suyashkumar wants to merge 10 commits intomainfrom
Open
Return an error if Pixel Representation is signed and a signed native is pixel data value is found.#296suyashkumar wants to merge 10 commits intomainfrom
suyashkumar wants to merge 10 commits intomainfrom
Conversation
pixel data value is found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for #294, by returning an error in the case that the dicom indicates signed pixel data and a negative pixel data value is detected.
If users are passing the
SkipProcessingPixelDataValueorSkipPixelDataoption, this will bypass this error since this will only happen when trying to parse the raw Native PixelData.It would be useful to add more tests for other bit widths, and some of the tests can be better structured (which can happen in follow ups), but I'd like to get this in sooner rather than later. We can follow up on getting signed integers fully supported directly.