Ignore malformed LAN discovery replies - #5819
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
LAN discovery decodes each UDP reply directly in its request worker. A short reply could make BareNetworkString throw std::out_of_range and terminate that worker. Ignore replies that end while their fields are being decoded, leaving valid replies unchanged and allowing discovery to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LAN browser decodes every UDP reply in ServersManager::getLANRefreshRequest() on its request worker. A reply that ends before all advertised fields are present makes BareNetworkString throw std::out_of_range, which can terminate the discovery request.
Ignore replies that run out of data while they are decoded. Valid server replies follow the existing path unchanged, while malformed LAN packets no longer stop discovery.