Validate special ping packets before decoding - #5818
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
The receive loop accepted a five-byte ping prefix, then read a timestamp and a counted peer list without checking their lengths. Reject packets shorter than the fixed header or the advertised peer records before decoding them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client receive loop handles unencrypted ping packets before normal event parsing. It accepted any packet with the five-byte ping prefix, then read a timestamp and a counted peer list without first checking that those bytes were present. A malformed packet from a connected server could terminate the listening thread.
Check the fixed ping header before decoding it, then verify that the remaining packet contains every advertised peer record. Invalid ping packets are dropped before they reach the decoder.