Reject unsafe paths while extracting add-on ZIPs - #5817
Open
acts-1631 wants to merge 1 commit into
Open
Conversation
ZIP member names were appended directly to the add-on destination. A member containing traversal components could write outside that directory. Reject absolute, drive-qualified, empty, dot, and dot-dot path components before creating any directories or files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-on ZIP files are extracted recursively by extract_zip(). Archive member names were appended to the extraction directory without rejecting traversal components, allowing a ZIP entry with .. components to write outside the add-on tree.
Validate recursive member names before creating their parent directory or opening the output file. The check rejects absolute, drive-qualified, empty, dot, and dot-dot path components while preserving normal nested add-on files.