-
Notifications
You must be signed in to change notification settings - Fork 8
Added tests for CI and fixed yml file for SwiftLint #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 2 commits
09c0935
cb1e7d6
e539975
8b83a01
90ea2b4
3c11b14
4392f0b
1c30c44
cc613b0
4bf2553
39ed0fd
c84d34b
4ee22f9
95b4bfa
9b60a81
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,24 @@ | ||||||
| name: Swift | ||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| on: | ||||||
| pull_request: | ||||||
| branches: [ master ] | ||||||
| paths: | ||||||
| - '**/*.swift' | ||||||
| - '**/*.yml' | ||||||
|
|
||||||
| jobs: | ||||||
| test: | ||||||
| name: Run Swift Tests | ||||||
| runs-on: ubuntu-latest | ||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an interesting approach. Users of this tool should be using macOS, but making the tool cross-platform may have some value? |
||||||
|
|
||||||
| steps: | ||||||
| - name: Check out code | ||||||
| uses: actions/checkout@v2 | ||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not using the latest version? I think it's v4 now? |
||||||
|
|
||||||
| - name: Setup Swift | ||||||
| uses: swift-actions/setup-swift@v1.26.0 | ||||||
|
|
||||||
| - name: Run tests | ||||||
| run: swift test | ||||||
| working-directory: StringCatalogEnum | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: SwiftLint | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/swiftlint.yml' | ||
| - '.swiftlint.yml' | ||
| - '**/*.swift' | ||
|
|
||
| jobs: | ||
| SwiftLint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: GitHub Action for SwiftLint | ||
| uses: norio-nomura/action-swiftlint@3.2.1 | ||
| - name: GitHub Action for SwiftLint with --strict | ||
| uses: norio-nomura/action-swiftlint@3.2.1 | ||
| with: | ||
| args: --strict | ||
| - name: GitHub Action for SwiftLint (Only files changed in the PR) | ||
| uses: norio-nomura/action-swiftlint@3.2.1 | ||
| env: | ||
| DIFF_BASE: ${{ github.base_ref }} | ||
| - name: GitHub Action for SwiftLint (Different working directory) | ||
| uses: norio-nomura/action-swiftlint@3.2.1 | ||
| env: | ||
| WORKING_DIRECTORY: Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to
swift-unit-test.yml