This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Added ability to pass config manually#96
Open
enumag wants to merge 1 commit into
Open
Conversation
8172232 to
dbca7ce
Compare
|
Since you are using |
Author
|
The 5.4 array notation was not intended, KCFinder is currently compatible with 5.3 and it was not my intention to break it. Thanks for pointing it out. |
Author
|
@tomaswindsor Fixed compatibility with 5.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personally I don't like the configuration via session thing. Instead I want to have my own logic in my app that would check privileges and such and then call the KCFinder directly. Here is what I use in my project:
Now this means that the constructor should accept configuration array as an optional argument.
As a sideeffect since I have different URL it breaks autoloading, searching for lang files, javascript, css and such. I have fixed all that as well.