This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Rename "..png" to "period.png" for the sake of various tools out there that can't cope with a file named "..png"#88
Open
BenWoodford wants to merge 4 commits into
Open
Conversation
…an application (Laravel's vendor:publish for instance), "period.png" seems like a better choice.
Author
|
Ah, whoops. It seems I accidentally included my own hacks for Laravel Admin in this, I'll revert that in my dot-fix branch. |
added 2 commits
March 29, 2015 13:14
This reverts commit f23eb03.
|
Better fix: #97 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's likely this will need to do some file_exists() checking as it'll break various themes, but tools such as Laravel's artisan vendor:publish command can't deal with "..png" and instead treat it as going up one directory if not two.
It's not an ideal situation, but with so many problems that can happen using a naming format like this it seems like a sensible move to change it. I doubt ".period" is going to show up as an extension any time soon.