Skip to content

🐛(backend): fix inclusion of modules with uv_build#2295

Open
Ma27 wants to merge 1 commit into
suitenumerique:mainfrom
Ma27:uv_inclusion
Open

🐛(backend): fix inclusion of modules with uv_build#2295
Ma27 wants to merge 1 commit into
suitenumerique:mainfrom
Ma27:uv_inclusion

Conversation

@Ma27
Copy link
Copy Markdown
Contributor

@Ma27 Ma27 commented May 14, 2026

Purpose

Same fix as suitenumerique/meet#1199 for meet.

Proposal

n/a

External contributions

Thank you for your contribution! 🎉

Please ensure the following items are checked before submitting your pull request:

General requirements

Skip the checkbox below 👇 if you're fixing an issue or adding documentation

  • Before submitting a PR for a new feature I made sure to contact the product manager

CI requirements

  • I made sure that all existing tests are passing (build-system change, not applicable)
  • I have signed off my commits with git commit --signoff (DCO compliance)
  • I have signed my commits with my SSH or GPG key (git commit -S)
  • My commit messages follow the required format: <gitmoji>(type) title description
  • I have added a changelog entry under ## [Unreleased] section (if noticeable change)

AI requirements

Skip the checkboxes below 👇 If you didn't use AI for your contribution

  • I used AI assistance to produce part or all of this contribution
  • I have read, reviewed, understood and can explain the code I am submitting
  • I can jump in a call or a chat to explain my work to a maintainer

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f6f2d2f9-3e5e-4b0a-acf2-2371e902ec07

📥 Commits

Reviewing files that changed from the base of the PR and between 6c6db22 and 2de9012.

📒 Files selected for processing (3)
  • .github/workflows/impress.yml
  • src/backend/__init__.py
  • src/backend/pyproject.toml

Walkthrough

This PR updates two configuration files: it adds a module-name array ["core","demo","impress"] to [tool.uv.build-backend] in src/backend/pyproject.toml, and it changes the lint-back job in .github/workflows/impress.yml to run pylint only on the impress, demo, and core modules instead of the entire backend.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing module inclusion with uv_build, which is reflected in the pyproject.toml and workflow modifications.
Description check ✅ Passed The description is related to the changeset, referencing a similar fix applied to another project and explaining the purpose of the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lunika
Copy link
Copy Markdown
Member

lunika commented May 18, 2026

Thanks for your contribution.
I will rebase and merge it.

@lunika lunika force-pushed the uv_inclusion branch 2 times, most recently from 1252e22 to 6c6db22 Compare May 18, 2026 07:32
Same fix as suitenumerique/meet#1199.

Signed-off-by: Maximilian Bosch <maximilian@mbosch.me>
@lunika lunika enabled auto-merge (squash) May 18, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants