Run tests in parallel#2280
Conversation
|
🤖 Created branch: z_pr2280/skitt/parallel-ginkgo |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThe change migrates unit test execution in the build script from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@scripts/shared/unit_test.sh`:
- Around line 47-48: Update the stale comment that currently mentions "go test"
to accurately reference the test runner in use ("ginkgo") in
scripts/shared/unit_test.sh; locate the comment block around the earlier note
about reporting the test command's exit status and replace "go test" with
"ginkgo" (and optionally mention coverage/profile behavior specific to ginkgo)
so future editors are not misled by the incorrect test runner name.
| # It's important that the `go test` command's exit status is reported from this () block. | ||
| # Can't be one command (with -cover). Need detailed -coverprofile for Sonar and summary to console. |
There was a problem hiding this comment.
Update the stale go test comment.
Line 47 now refers to go test, but the command is ginkgo. This can mislead future edits.
🔧 Proposed fix
- # It's important that the `go test` command's exit status is reported from this () block.
- # Can't be one command (with -cover). Need detailed -coverprofile for Sonar and summary to console.
+ # It's important that the `ginkgo` command's exit status is reported from this () block.
+ # Can't be one command (with -cover). Need detailed -coverprofile for Sonar and summary to console.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # It's important that the `go test` command's exit status is reported from this () block. | |
| # Can't be one command (with -cover). Need detailed -coverprofile for Sonar and summary to console. | |
| # It's important that the `ginkgo` command's exit status is reported from this () block. | |
| # Can't be one command (with -cover). Need detailed -coverprofile for Sonar and summary to console. |
🤖 Prompt for AI Agents
In `@scripts/shared/unit_test.sh` around lines 47 - 48, Update the stale comment
that currently mentions "go test" to accurately reference the test runner in use
("ginkgo") in scripts/shared/unit_test.sh; locate the comment block around the
earlier note about reporting the test command's exit status and replace "go
test" with "ginkgo" (and optionally mention coverage/profile behavior specific
to ginkgo) so future editors are not misled by the incorrect test runner name.
This uses the Ginkgo driver directly to allow running the tests in parallel. Signed-off-by: Stephen Kitt <skitt@redhat.com>
de7f68b to
e5ef083
Compare
|
What is the motivation for running unit tests is parallel, especially at this point? This will likely cause issues in some test suites that modify shared globals. |
This is just a draft to measure the impact. The motivation is to reduce the time spent waiting for tests (but it would be more useful on e2e). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
This uses the Ginkgo driver directly to allow running the tests in parallel.
Summary by CodeRabbit